Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35440 )
Change subject: intel/ibexpeak boards: Remove handled RCBA entries from replay ......................................................................
Patch Set 13:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35440/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35440/1//COMMIT_MSG@9 PS1, Line 9: elsewhere
Where?
Mostly in southbridge ramstage code. I don't think it's necessary to provide an exhaustive list.
https://review.coreboot.org/c/coreboot/+/35440/4/src/mainboard/lenovo/x201/r... File src/mainboard/lenovo/x201/romstage.c:
https://review.coreboot.org/c/coreboot/+/35440/4/src/mainboard/lenovo/x201/r... PS4, Line 68: hiders
hides
Done
https://review.coreboot.org/c/coreboot/+/35440/11/src/mainboard/lenovo/x201/... File src/mainboard/lenovo/x201/romstage.c:
https://review.coreboot.org/c/coreboot/+/35440/11/src/mainboard/lenovo/x201/... PS11, Line 71: (1 << 5) | (1 << 6) | (1 << 7) | (1 << 8) | (1 << 9) : | (1 << 10) | (1 << 11) | (1 << 12) | (1 << 28) | 1;
- What's bit 28? the comment doesn't mention it. […]
Done
https://review.coreboot.org/c/coreboot/+/35440/12/src/mainboard/lenovo/x201/... File src/mainboard/lenovo/x201/romstage.c:
https://review.coreboot.org/c/coreboot/+/35440/12/src/mainboard/lenovo/x201/... PS12, Line 70: present in end user devices anyway. */
don't seem to be ? […]
Done
https://review.coreboot.org/c/coreboot/+/35440/12/src/mainboard/packardbell/... File src/mainboard/packardbell/ms2290/romstage.c:
https://review.coreboot.org/c/coreboot/+/35440/12/src/mainboard/packardbell/... PS12, Line 65: present in end user devices anyway. */
like x201
Done