[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake: Fix value stored to gnvs is never read

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32903 )

Change subject: soc/intel/apollolake: Fix value stored to gnvs is never read
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32903/2/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/32903/2/src/soc/intel/apollolake/chip.c@a421 
PS2, Line 421:
> Common code southbridge_inject_dsdt already takes care of gnvs. gnvs=cbmem_find(CBMEM_ID_ACPI_GNVS). […]

gnvs is used by other blocks in common code as well e.g. uart. Did you verify the order between calls to southbridge_inject_dsdt() and other consumers of gnvs? soc_init is run as part of chip enable which happens before any device enable. It would be good to verify the order.