Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39299 )
Change subject: mb/asus/p8z77-v_lx2: Add new mainboard ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39299/4/src/mainboard/asus/p8z77-v_... File src/mainboard/asus/p8z77-v_lx2/early_init.c:
https://review.coreboot.org/c/coreboot/+/39299/4/src/mainboard/asus/p8z77-v_... PS4, Line 57: /* Power RAM in S3 */
Sorry, no that I have the datasheet, add “3VSBSW# enable bit” in the comment too?
The idea is that these comments provide a high-level explanation of what the code is doing. If somebody wants to know what this write to the ACPI device is exactly doing, they can check the datasheet.
https://review.coreboot.org/c/coreboot/+/39299/4/src/mainboard/asus/p8z77-v_... PS4, Line 63: /* Enable UART */
Either remove, as it’? obvious from `serial` in the function name, or *Enable UART A*.
There's no other UART on the board. As other boards have this comment (maybe not in the correct place, though), I would prefer to keep it.