22 Dec
2019
22 Dec
'19
8:20 p.m.
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37822 )
Change subject: mainboard/google/puff: Don't en MAX98357A in dt ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... PS3, Line 6: DRIVERS_I2C_DA7219
What about this one? […]
Or maybe just leave these enabled? Does it really matter if they are enabled in KConfig but not used via dt?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37822
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e437d9cd5c4bf66d39e290cc9153e08e32a3389
Gerrit-Change-Number: 37822
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz djkurtz@google.com
Gerrit-CC: Kangheui Won khwon@chromium.org
Gerrit-Comment-Date: Mon, 23 Dec 2019 04:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Kurtz djkurtz@google.com
Gerrit-MessageType: comment