[coreboot-gerrit] Change in coreboot[master]: [TEST] Helios: Add fan speed control for TSR3 sensor with DPTF settings

[Puthikorn Voravootivat (Code Review)]

Puthikorn Voravootivat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41425 )

Change subject: [TEST] Helios: Add fan speed control for TSR3 sensor with DPTF settings
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41425/4/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/41425/4/src/mainboard/google/hatch/... 
PS4, Line 93: 100
> My understanding is that 'Weight' is a number indicating how much of an effect (relatively speaking) […]

The 100 is weight. Since every thing is 100, there is no effect here. The example of this is you can use weight to throttle charger before cpu.

The 90/80/60... are fan speed.

So at DPTF_TSR3_ACTIVE_AC0 (50C) fan run at speed 90 (=6700 rpm)

But the fan speed is probably trigger sooner from TSR1, 6700rpm @ 43C (DPTF_TSR1_ACTIVE_AC0)