Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39839 )
Change subject: lp/drivers/usb: Add quirk for QEMU XHCI root hub ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/generic_hub.c:
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... PS2, Line 222: hub_status_changed
I actually looked at that first, it is a bit messy because the RH is added before the PCI device is […]
I don't see that, xhci_pci_init() calls xhci_init() calls xhci_rh_init(). What do I miss?
Beside not providing `.hub_status_changed` we could also let it return 1 for the Qemu implementation. Sorry for squabbling but it feels wrong to add quirk handling to work around an existing interface.
If we end up handling it here, we should be honest and name the quirk
USB_QUIRK_SPURIOUS_HUB_STATUS_CHANGED_FUNCTION
Beside all that, do we actually benefit from having `.hub_status_change`? I probably just added it because there seemed to be a reliable PCD bit... No other generic hub implementation uses it (OHCI could, if anybody would wanted to port it forward... before we abandon it).