Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29469 )
Change subject: mb/google/kahlee: edp panel initialization time tuning
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29469/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29469/4//COMMIT_MSG@12
PS4, Line 12: GPIO EP133 to high as default
This makes no sense with the actual code change. Originally it was being set to HIGH, now is being set to LOW. Add some explanation to gpio.c or add a better explanation here.
--
To view, visit
https://review.coreboot.org/29469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb
Gerrit-Change-Number: 29469
Gerrit-PatchSet: 4
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Mon, 05 Nov 2018 16:58:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No