Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33232 )
Change subject: src/cpu/x86: Check pointer processor_name_start before dereference
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33232/2/src/cpu/x86/name/name.c
File src/cpu/x86/name/name.c:
https://review.coreboot.org/#/c/33232/2/src/cpu/x86/name/name.c@40
PS2, Line 40: processor_name_start
I think clang is misleading here. You just want to make sure you're not dereferencing somthing outside the memory allocated for name_as_ints.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f831a8661a4686d306b8217655942934102ea16
Gerrit-Change-Number: 33232
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Jun 2019 13:00:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment