Change in ...coreboot[master]: src/cpu/x86: Check pointer processor_name_start before dereference

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in vboot[master]: vboot:...

John Zhao (Code Review)

5 Jun 2019 5 Jun '19

6:29 p.m.

John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33232

Change subject: src/cpu/x86: Check pointer processor_name_start before dereference ......................................................................

src/cpu/x86: Check pointer processor_name_start before dereference

Clang Static Analyzer version 8.0.0 detects the left operand of '==' is a garbage value if pointer processor_name_start is NULL. Add sanity check for processor_name_start before dereference.

TEST=Built and boot up to kernel.

Change-Id: I1f831a8661a4686d306b8217655942934102ea16 Signed-off-by: John Zhao john.zhao@intel.com --- M src/cpu/x86/name/name.c 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33232/1

diff --git a/src/cpu/x86/name/name.c b/src/cpu/x86/name/name.c index fc360cd..44a1cf0 100644 --- a/src/cpu/x86/name/name.c +++ b/src/cpu/x86/name/name.c @@ -37,6 +37,9 @@

/* Skip leading spaces. */ processor_name_start = (char *)name_as_ints; + if (!processor_name_start) + return; + while (*processor_name_start == ' ') processor_name_start++;

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Arthur Heymans (Code Review)

6 Jun 6 Jun

1:35 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33232 )

Change subject: src/cpu/x86: Check pointer processor_name_start before dereference ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33232/1/src/cpu/x86/name/name.c File src/cpu/x86/name/name.c:

https://review.coreboot.org/#/c/33232/1/src/cpu/x86/name/name.c@39 PS1, Line 39: name_as_ints how can this ever be NULL?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f831a8661a4686d306b8217655942934102ea16 Gerrit-Change-Number: 33232 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-Comment-Date: Wed, 05 Jun 2019 23:35:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Zhao (Code Review)

9:15 p.m.

Hello Balaji Manigandan, Lijian Zhao, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33232

to look at the new patch set (#2).

Change subject: src/cpu/x86: Check pointer processor_name_start before dereference ......................................................................

src/cpu/x86: Check pointer processor_name_start before dereference

Clang Static Analyzer version 8.0.0 detects the left operand of '==' is a garbage value if pointer processor_name_start is NULL. Add sanity check for processor_name_start before dereference.

TEST=Built and boot up to kernel.

Change-Id: I1f831a8661a4686d306b8217655942934102ea16 Signed-off-by: John Zhao john.zhao@intel.com --- M src/cpu/x86/name/name.c 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33232/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f831a8661a4686d306b8217655942934102ea16 Gerrit-Change-Number: 33232 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

John Zhao (Code Review)

9:19 p.m.

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33232 )

Change subject: src/cpu/x86: Check pointer processor_name_start before dereference ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33232/1/src/cpu/x86/name/name.c File src/cpu/x86/name/name.c:

https://review.coreboot.org/#/c/33232/1/src/cpu/x86/name/name.c@39 PS1, Line 39: name_as_ints

...

how can this ever be NULL?

Moved the check after processor_name_start++ operation.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f831a8661a4686d306b8217655942934102ea16 Gerrit-Change-Number: 33232 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Jun 2019 19:19:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Arthur Heymans (Code Review)

8 Jun 8 Jun

3 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33232 )

Change subject: src/cpu/x86: Check pointer processor_name_start before dereference ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33232/2/src/cpu/x86/name/name.c File src/cpu/x86/name/name.c:

https://review.coreboot.org/#/c/33232/2/src/cpu/x86/name/name.c@40 PS2, Line 40: processor_name_start I think clang is misleading here. You just want to make sure you're not dereferencing somthing outside the memory allocated for name_as_ints.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f831a8661a4686d306b8217655942934102ea16 Gerrit-Change-Number: 33232 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 08 Jun 2019 13:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Zhao (Code Review)

20 May 20 May

6:44 p.m.

New subject: Change in coreboot[master]: src/cpu/x86: Check pointer processor_name_start before dereference

John Zhao has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33232 )

Change subject: src/cpu/x86: Check pointer processor_name_start before dereference ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/33232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f831a8661a4686d306b8217655942934102ea16 Gerrit-Change-Number: 33232 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1431

days inactive

1781

days old

coreboot-gerrit@coreboot.org

5 comments

2 participants

tags (0)

participants (2)

Arthur Heymans (Code Review)
John Zhao (Code Review)