Attention is currently required from: Appukuttan V K, Ronak Kanabar.
Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82425?usp=email )
Change subject: vc/edk2-stable202302: Add config guards to support FSP 2.4 ......................................................................
Patch Set 23:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82425/comment/b6097ab9_2dacff5e?usp... : PS23, Line 16: - Guard x86_32 architecture specific structures under : PLATFORM_USES_FSP2_X86_32 config. : - Guard FSP 2.4 specific structures under PLATFORM_USES_FSP2_4 : config. how do EDK2 manages to support 32-bit and/or 64-bit boot loader so far w/o the specific guard ?
File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:
https://review.coreboot.org/c/coreboot/+/82425/comment/a2110544_fac9687f?usp... : PS23, Line 382: } FSPT_UPD_COMMON_FSP24; this also should be guarded with `PLATFORM_USES_FSP2_4`