Jonas Löffelholz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42804 )
Change subject: mb/prodrive/hermes/variants/baseboard: configure sataHotplug ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: src/
remove
Done
https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: mainboard
mainboard/ can be shortened to mb/
Done
https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/prodrive/hermes/variants/baseboard: add support for sata hotswap
too much characters per line
Done
https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@8 PS1, Line 8:
Missing commit message. […]
Done
https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... PS1, Line 24: register "SataPortsHotPlug[2]" = "1"
only enable hot plug on enabled sata ports
Done