[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/fatcat: Optimize CBFS backed option API

[Kapil Porwal (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Julius Werner, Nick Vaccaro, Paul Menzel, Pranava Y N, Subrata Banik.

Kapil Porwal has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/87286?usp=email )

Change subject: mb/google/fatcat: Optimize CBFS backed option API
......................................................................

Patch Set 5:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/87286/comment/61ae1342_b8311e06?usp... :
PS4, Line 7: CBFE
> CBF*S*

Acknowledged

https://review.coreboot.org/c/coreboot/+/87286/comment/f0f21e67_f9f18d74?usp... :
PS4, Line 9: Added
> Add

Acknowledged

https://review.coreboot.org/c/coreboot/+/87286/comment/58d634ae_6dd33737?usp... :
PS4, Line 9: traversal
> Of what?

Acknowledged

https://review.coreboot.org/c/coreboot/+/87286/comment/559099bb_455a851e?usp... :
PS4, Line 10: then
> th*a*n

Acknowledged

https://review.coreboot.org/c/coreboot/+/87286/comment/172ed05d_8e4c11f3?usp... :
PS4, Line 10: look up
> lookup

Acknowledged

File src/mainboard/google/brya/common.c:

https://review.coreboot.org/c/coreboot/+/87286/comment/1ed09e69_ac926ae1?usp... :
PS4, Line 7: valid_options
> valid_cbfs_options

Acknowledged

https://review.coreboot.org/c/coreboot/+/87286/comment/2465be25_290dbcd5?usp... :
PS4, Line 7: static const char * const valid_options[] = {
           : 	"fsp_pcd_debug_level",
           : 	"fsp_mrc_debug_level"
           : };
> these options are only for PTL onwards

Acknowledged

https://review.coreboot.org/c/coreboot/+/87286/comment/4621e6a1_ab6f5d30?usp... :
PS4, Line 19: int
> size_t

Acknowledged