Attention is currently required from: Subrata Banik, Ivy Jian.
Hello build bot (Jenkins), Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67422
to look at the new patch set (#5).
Change subject: mb/google/rex: Fix interrupt config for audio devices ......................................................................
mb/google/rex: Fix interrupt config for audio devices
Use the new `PAD_CFG_GPI_APIC_EDGE_BOTH` macro to specify the headset codec interrupt as specifically edge triggered (since it is registered as EDGE_BOTH in the devicetree) in order to prevent the interrupt from firing unexpectedly.
BUG=b:232573696 TEST=Unable to see IRQ error on Google/rex with this change.
Without this change:
localhost ~ # dmesg | grep 5682 [ 44.618776] acpi RTL5682:00: GPIO: looking up 0 in _CRS [ 44.636740] rt5682s i2c-RTL5682:00: Using default DAI clk names: rt5682-dai-wclk, rt5682-dai-bclk [ 44.647601] rt5682s i2c-RTL5682:00: supply AVDD not found, using dummy regulator [ 44.661451] rt5682s i2c-RTL5682:00: supply MICVDD not found, using dummy regulator [ 44.890652] genirq: Failed to request resources for rt5682s (irq 169) on irqchip INTC1083:00 [ 44.907244] rt5682s i2c-RTL5682:00: Failed to reguest IRQ: -22
With this change:
localhost~ # dmesg | grep 5682 [ 1.856825] ACPI: Enabled 2 GPEs in block 00 to 7F [ 65.854382] rt5682s i2c-RTL5682:00: Using default DAI clk names: rt5682-dai-wclk, rt5682-dai-bclk [ 65.855288] rt5682s i2c-RTL5682:00: supply AVDD not found, using dummy regulator [ 65.855682] rt5682s i2c-RTL5682:00: supply MICVDD not found, using dummy regulator
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I0ba65b1ddeea21c35ab01d9c2ef3b47c0c39441a --- M src/mainboard/google/rex/variants/rex0/gpio.c M src/mainboard/google/rex/variants/rex0/overridetree.cb 2 files changed, 37 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/67422/5