Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39331 )
Change subject: src/*: Make PCI ID macro names shorter
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Needs a little more work and somebody with a lot of time to re-align
the whole `pci_ids.h`. But generally: Kill the boilerplate!
https://review.coreboot.org/c/coreboot/+/39331/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39331/1//COMMIT_MSG@14
PS1, Line 14: ;
Could have used `+` instead of `;` ;) should be much faster.
https://review.coreboot.org/c/coreboot/+/39331/1//COMMIT_MSG@14
PS1, Line 14: find -type f -exec sed -i 's/PCI_VENDOR_ID_/PCI_VID_/' {} ;
Missing `g` modifier for the substitution. There are some lines with
multiple occurence (probably unused, as Jenkins didn't complain).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9027700f53b6d0d3964c26a41a1f9b8f62be178
Gerrit-Change-Number: 39331
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 13:37:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment