Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38006 )
Change subject: usbdebug: Fix printk conversion
......................................................................
Patch Set 2:
Did the compiler warn about that?
I don't think we have format warnings enabled. If we have, a
compiler should have warned in the 64-bit case. To be honest,
I have no idea how varargs are implemented for 64-bit targets.
If it's not aligning every argument to at least 64 bits, it
would have printed the wrong numbers.
Does this also work with 64-bit compilation?
`%lx` is safe for all our targets, 32 and 64 bits, because a
long matches the pointer size for all of them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dba96004de264fe1faf5485fb677a6b05123bba
Gerrit-Change-Number: 38006
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 03 Jan 2020 13:09:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment