[coreboot-gerrit] [S] Change in coreboot[main]: util/superiotool: Add extra selectors support

[Maxim (Code Review)]

Attention is currently required from: Angel Pons, Felix Held, Paul Menzel.

Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83196?usp=email )

Change subject: util/superiotool: Add extra selectors support
......................................................................

Patch Set 3:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83196/comment/ec8bcf7a_f578adcb?usp... :
PS2, Line 9: ,
> nit: this comma looks odd. Were you going to add something here? […]

Removed

https://review.coreboot.org/c/coreboot/+/83196/comment/c37bb93a_69a5d37e?usp... :
PS2, Line 38: the motherboard
> Which one?

Asrock H110-STX

File util/superiotool/superiotool.h:

https://review.coreboot.org/c/coreboot/+/83196/comment/01446b8b_0a20be51?usp... :
PS2, Line 140: typedef struct {
             : 	const char *name;
             : 	uint8_t idx;
             : 	uint8_t mask;
             : 	uint8_t val;
             : } extra_selector_t;
> Please, no typedefs: https://doc.coreboot.org/contributing/coding_style.html#typedefs […]

Done

File util/superiotool/superiotool.c:

https://review.coreboot.org/c/coreboot/+/83196/comment/65fd6dfb_641d5df2?usp... :
PS2, Line 87: {
> nit: move brace to new line […]

Fixed
(Sometimes this happens if switch between C and Go)

https://review.coreboot.org/c/coreboot/+/83196/comment/ed9095c9_46b37765?usp... :
PS2, Line 96: (~esel->mask)
> I'd say it would make more sense to invert the mask, i.e. […]

Done

https://review.coreboot.org/c/coreboot/+/83196/comment/da55f6bf_143e02a4?usp... :
PS2, Line 98: 	/* -- ESEL[27h] : 0x00 (Port Select Register) -- */
> Since these comments are specific to a chip, I would prefer to remove them as they can cause confusi […]

Done