[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82371eb: Add support for reconfiguring GPO22/23

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38352 )

Change subject: sb/intel/i82371eb: Add support for reconfiguring GPO22/23
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... 
File src/southbridge/intel/i82371eb/chip.h:

https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... 
PS4, Line 32: int gpo22:1;
            : 	int gpo23:1;
            : 	int pad:5;
> I don't think padding is required. After all, the struct isn't used as a whole. […]

The compiler will automatically layout the struct, and we don't care about the layout a lot (because it's never sent into hardware verbatim) so no padding needed here.