Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go... PS13, Line 87: /* TODO: create it as header files as other boards */
no.
I see the gpio.h->gpio.c change in google/slippy.
https://review.coreboot.org/c/coreboot/+/30890/13/util/autoport/lynxpoint.go... PS13, Line 278: romstage.c
I've changed the format of this file substantially with topic:haswell-pei-data-noises. […]
Done
https://review.coreboot.org/c/coreboot/+/30890/15/util/autoport/lynxpoint.go File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/15/util/autoport/lynxpoint.go... PS15, Line 330: /* FIXME: sata_*_gen3_dtle don't seem to be useful, just keep them here */ Hmm,these looks necessary. Linux can report I/O errors on ATA when this is not set. But why are there only two ports to set?