Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47226 )
Change subject: soc/intel/jasperlake: Log PM event from an internal device
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47226/1/src/soc/intel/jasperlake/el...
File src/soc/intel/jasperlake/elog.c:
https://review.coreboot.org/c/coreboot/+/47226/1/src/soc/intel/jasperlake/el...
PS1, Line 21: reg_offset
We probably don't need the reg_offset. We should be able to use `pci_dev_is_wake_source()`. […]
I added a `pci_s_dev_is_wake_source` function for the simple device model (used in SMM) for elog, would be good to rebase on top of CB:47183 to use that function. Then I can add TCSS IPs to elog for TGL too based on top of yours
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f43675b698bf310f6b98b5e775d1259607abbcd
Gerrit-Change-Number: 47226
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 21:59:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment