[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Steal no memory for disabled IGD

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )

Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD
......................................................................

Patch Set 14: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/39454/13/src/soc/intel/cannonlake/r... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/39454/13/src/soc/intel/cannonlake/r... 
PS13, Line 167: 		tconfig->PanelPowerEnable = 0;
> Why do we need to merge this? This would be that we have yo update the implementation which is alway […]

This could be done in a separate change, IMHO.

https://review.coreboot.org/c/coreboot/+/39454/14/src/soc/intel/cannonlake/r... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/39454/14/src/soc/intel/cannonlake/r... 
PS14, Line 28: 	 * to prevent a crash in FSP-M.
Maybe also mention that disabling the panel power controls in tconfig is required?

https://review.coreboot.org/c/coreboot/+/39454/14/src/soc/intel/cannonlake/r... 
PS14, Line 31: 			pci_read_config16(SA_DEV_IGD, PCI_VENDOR_ID) != 0xffff) {
I thiiink it fits in one line now