Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31635 )
Change subject: intel/skylake: nhlt: Add 24 bit blobs for Max98373
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31635/2/src/soc/intel/skylake/nhlt/Makefile....
File src/soc/intel/skylake/nhlt/Makefile.inc:
https://review.coreboot.org/#/c/31635/2/src/soc/intel/skylake/nhlt/Makefile....
PS2, Line 57: cbfs-files-$(CONFIG_NHLT_MAX98373) += $(MAX98373_RENDER_16B)
: $(MAX98373_RENDER_16B)-file := $(NHLT_BLOB_PATH)/$(MAX98373_RENDER_16B)
: $(MAX98373_RENDER_16B)-type := raw
Shouldn't this be removed as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31635
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62cc109fb0aca9269736779a6ce80980b0571b78
Gerrit-Change-Number: 31635
Gerrit-PatchSet: 2
Gerrit-Owner: Jenny Tc
jenny.tc@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jenny Tc
jenny.tc@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jenny Tc
jenny.tc@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Apr 2019 15:40:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment