[coreboot-gerrit] Change in coreboot[master]: acpi: Add support for reporting CrashLog in BERT table

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )

Change subject: acpi: Add support for reporting CrashLog in BERT table
......................................................................

Patch Set 10:

(1 comment)

Patchset:

PS10:
> The Key here is understanding the picture I provided to see how the raw data concept fully fit into  […]

CB:55006 is supposed to be used in combination with CB:54738 , right?

sure, the generation of the data structures in the bert region is and should be soc-specific. the acpi code that generates the bert ssdt that points to the bert memory region if there's something in there should be generic code though https://review.coreboot.org/c/coreboot/+/54149/2/src/soc/amd/picasso/agesa_a... while this https://review.coreboot.org/c/coreboot/+/49799/10/src/acpi/acpi.c#1585 introduces two more functions that are implemented in the intel soc code despite common functionality for this already being available in the existing common bert code