[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Set up Wake GPIO from EC

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31100 )

Change subject: mb/google/hatch: Set up Wake GPIO from EC
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31100/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31100/1//COMMIT_MSG@13 
PS1, Line 13:  Make sure device wakes up
> Did lidopen, keyboard press also wake up the AP?

No, but I couldn't see any hostevents set for either of those, so I thought that it was because the EC wasn't actually setting PCH_WAKE_L (I didn't see it set when I did a gpioget PCH_WAKE_L).  So, I tested it by gpiosetting PCH_WAKE_L to 0 and the device did indeed wake up as a result.