Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/28767 )
Change subject: amd/stoneyridge: Load AOAC and USB gnvs values ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 914: 1;
No, not certain. This will eventually be used for SD. I'll update the source.
Search for "AOACx[7F:41:step2] Device D3 State" in the NDA BKDG (probably also available in the public one), and you'll understand the values of 0x5F, 0x71 and 0x77. The even offsets is for D3 control, the odd ones for D3 state. And yes, procedure is_aoac_device_enabled() was created to use specifically these offsets when checking if a device is enabled (D0) or disabled (D3).