Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44915 )
Change subject: soc/intel/common: Add SSDT generation for Intel USB4 PCIe ports ......................................................................
Patch Set 12: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44915/12/src/soc/intel/common/block... File src/soc/intel/common/block/usb4/Kconfig:
https://review.coreboot.org/c/coreboot/+/44915/12/src/soc/intel/common/block... PS12, Line 12: HAVE_ACPI_TABLES Not required since the driver is doing more than just handling ACPI tables?
https://review.coreboot.org/c/coreboot/+/44915/12/src/soc/intel/common/block... File src/soc/intel/common/block/usb4/pcie.c:
https://review.coreboot.org/c/coreboot/+/44915/12/src/soc/intel/common/block... PS12, Line 51: port_id = PCI_FUNC(dev->path.pci.devfn); I am still not completely sure about this. I don't think we should represent the dummy/virtual device created under the RP as PCI device. Posted a comment on next CL in this series as well.