Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37584 )
Change subject: soc/intel/{cnl,icl,skl,tgl,common}: Make changes to send_heci_reset_req_message()
......................................................................
Patch Set 21:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37584/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/37584/6/src/soc/intel/common/block/...
PS6, Line 604:
Yes, it requires. I will push separate patch to address your comment.
The patch implements prerequisites https://review.coreboot.org/c/coreboot/+/38800/1
https://review.coreboot.org/c/coreboot/+/37584/6/src/soc/intel/common/block/...
PS6, Line 612: heci_reset
It resets HECI interface to ensure syncronization between CSE & Host for communication.
Done
https://review.coreboot.org/c/coreboot/+/37584/6/src/soc/intel/common/block/...
PS6, Line 617: CSE_RESET_ONLY
Currently, no external doc talk about CSE_RESET_ONLY. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37584
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I979b169a5bb3a5d4028ef030bcef2b8eeffe86e3
Gerrit-Change-Number: 37584
Gerrit-PatchSet: 21
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 09 Feb 2020 14:00:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment