[coreboot-gerrit] Change in coreboot[master]: soc/intel: Add Intel Xeon Scalable Processor support

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )

Change subject: soc/intel: Add Intel Xeon Scalable Processor support
......................................................................

Patch Set 33:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38548/33/src/soc/intel/xeon_sp/acpi... 
File src/soc/intel/xeon_sp/acpi.c:

https://review.coreboot.org/c/coreboot/+/38548/33/src/soc/intel/xeon_sp/acpi... 
PS33, Line 18: #include <assert.h>
             : #include <arch/acpi.h>
             : #include <arch/cpu.h>
             : #include <arch/acpigen.h>
             : #include <arch/ioapic.h>
             : #include <arch/smp/mpspec.h>
             : #include <string.h>
             : #include <cpu/intel/turbo.h>
             : #include <cpu/x86/smm.h>
             : #include <intelblocks/acpi.h>
             : #include <intelblocks/msr.h>
             : #include <intelblocks/pmclib.h>
             : #include <device/pci.h>
             : #include <cbmem.h>
             : #include <soc/acpi.h>
             : #include <soc/cpu.h>
             : #include <soc/soc_util.h>
             : #include <soc/pm.h>
             : #include <soc/pmc.h>
             : #include <soc/pci_devs.h>
             : #include <soc/hob_iiouds.h>
             : #include <soc/hob_memmap.h>
             : #include "chip.h"
Are you using all of those includes ?

Please clean and include only what you use.
(Please check the other files)