Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32405 )
Change subject: mb/google/kohaku: Update overridetree.cb ......................................................................
Patch Set 6:
(9 comments)
https://review.coreboot.org/#/c/32405/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/#/c/32405/1/src/mainboard/google/hatch/variants/... PS1, Line 73: ACPI_IRQ_WAKE_EDGE_LOW
Ok, so should I comment out the wake pin for now?
Done
https://review.coreboot.org/#/c/32405/5/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/#/c/32405/5/src/mainboard/google/hatch/variants/... PS5, Line 82: reset_gpio
generic.
Done
https://review.coreboot.org/#/c/32405/5/src/mainboard/google/hatch/variants/... PS5, Line 83: reset_delay_ms
generic.
Done
https://review.coreboot.org/#/c/32405/5/src/mainboard/google/hatch/variants/... PS5, Line 84: has_power_resource
generic.
Done
https://review.coreboot.org/#/c/32405/5/src/mainboard/google/hatch/variants/... PS5, Line 91: GPIO
GPP?
Done
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 32: }
},
Done
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 35: }
},
Done
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 41: }
},
Done
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 70: GPIO_D21_IRQ
GPP_D21_IRQ
Something must be wrong in my tree. I'm running "emerge-hatch coreboot" to build all the images, but obviously a typo like this should get caught... I need to figure out why the kohaku image isn't being compiled...