cedarhouse1@comcast.net has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38657 )
Change subject: arch/x86/include/arch: Add ROM_TASK_STATE_SEG ......................................................................
Patch Set 1:
(1 comment)
I would like get resolution on which header file to use for the smm_relocate_gdt in src/cpu/x86/smm/smm_stub.S
I originally proposed smm_segs.h (arch/x86/include/arc) but was rejected and has since been abandoned.
https://review.coreboot.org/c/coreboot/+/38657/1/src/arch/x86/include/arch/r... File src/arch/x86/include/arch/rom_segs.h:
https://review.coreboot.org/c/coreboot/+/38657/1/src/arch/x86/include/arch/r... PS1, Line 20: ROM_TASK_STATE_SEG
That segment doesn't exist in romstage gdt, see src/arch/x86/gdt_init. […]
The gdt that is referenced for the STM setup, for the SMM descriptor table, is the smm_relocate_gdt, which is in src/cpu/x86/smm_stub.S
I chose rom_segs.h out of the header files that you restricted me to because its defines matched the smm_relocate_gdt's offsets. I had to add the ROM_TASK_STATE_SEG because the STM setup code needs to properly setup the tr reg.
Originally, the smm_segs.h header file was created to match the smm_relocate_gdt but was rejected.
Given this information, what would you like me to do. If you have any questions please ask.