Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39136 )
Change subject: mb/google/dedede: Add memory initialization support for dedede
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39136/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/39136/5/src/mainboard/google/dedede...
PS5, Line 16: select GENERIC_SPD_BIN
Nit: Sorted in alphabetical order. […]
Done
https://review.coreboot.org/c/coreboot/+/39136/5/src/mainboard/google/dedede...
PS5, Line 72: config DIMM_SPD_SIZE
Nit: Move it after config DEVICETREE. This is sorted in alphabetical order.
Done
https://review.coreboot.org/c/coreboot/+/39136/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledoo/memory.c:
https://review.coreboot.org/c/coreboot/+/39136/5/src/mainboard/google/dedede...
PS5, Line 23: SMBUS
CBFS
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7248861efd1ecd5a0df0e17d39a44c168cab200e
Gerrit-Change-Number: 39136
Gerrit-PatchSet: 9
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 29 Feb 2020 16:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment