Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37895 )
Change subject: arch/x86: Top align bootblock program ......................................................................
Patch Set 4:
(3 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... PS2, Line 33: *(.bootblock.top);
The FIT table is also sitting within the last 4KiB. […]
Only the FIT pointer is/was near the top, object section was in section .rom.data in CB:37955 for FIT.
Should we introduce .bootblock.id and .bootblock.fit ?
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... PS2, Line 37: 16
What are the 16 bytes for?
I moved the comment below upwards.
It's copy paste from (now removed) https://review.coreboot.org/c/coreboot/+/37335/7/src/arch/x86/failover.ld
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... PS2, Line 45: 0xf0
I'm not following this sequence either. I think there needs some more explanation.
This was the hard-coded reserve for id.S and fit.S.