mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31019 )
Change subject: spi/winbond.c: change protection_granularity_shift for W25Q256* from 16 to 19
......................................................................
Patch Set 1:
Patch Set 1:
For SEC=0:
https://www.winbond.com/resource-files/w25q256jv%20spi%20revb%2009202016.pdf
Page 20
The smallest "Protected density" is 64KB which is 1 << 16.
https://www.winbond.com/resource-files/w25q128fv_revhh1_100913_website1.pdf
Page 22
The smallest "Protected density" is 256KB which is 1 << 18.
Patrick, thank you very much for providing this info and stopping my (as it turned out) harmful patch. I will abandon it now
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I488d20898fccd1e967334fdd982b31eedf48f412
Gerrit-Change-Number: 31019
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 21 Jan 2019 19:20:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment