Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31104
Change subject: util/ifdtool: Add lock support for cnl and icl ......................................................................
util/ifdtool: Add lock support for cnl and icl
Cannonlake and Icelake have same read/write region permission settings with skylake and kabylake, so add it here as well.
BUG=b:123199222 TEST=Turn on CONFIG_LOCK_MANAGEMENT_ENGINE and build image, check the setting matches 0x0D for read and 0x04 for write.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I71d8b815c7dff7dcbcff2bf77c85ebf80b8df6d2 --- M util/ifdtool/ifdtool.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/31104/1
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 69cd2a9..1181e8c 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -965,6 +965,8 @@ /* TXE can only write Device Expansion */ fmba->flmstr2 |= 0x20 << wr_shift; break; + case PLATFORM_CNL: + case PLATFORM_ICL: case PLATFORM_SKLKBL: /* CPU/BIOS can read descriptor, BIOS and GbE. */ fmba->flmstr1 |= 0xb << rd_shift;