Attention is currently required from: Andrey Petrov, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60639 )
Change subject: drivers/intel/fsp2_0/notify.c: Group per-phase data
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I liked it, thanks for addressing super quickly, next I will rebase CB:60402 to add a new structure […]
Sounds good. I'd store `skip` instead of `allowed` so that notify phases that can't be skipped don't need to set `.allowed = true,`. This is also in line with the Kconfig options containing `SKIP` in their names.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4ab3d87edfcd5426ce35c168cbb780ade87290e
Gerrit-Change-Number: 60639
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 01 Jan 2022 17:49:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment