Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45652 )
Change subject: util/cbfstool: Add Alignment for CBnT
......................................................................
Patch Set 15:
I don't think this change is really necessary. All this does is mark the bootblock with the IBB CBFS attribute which is unused with CbNT (IBB marking is done via BPM, not via FIT) and align it to 64 bytes which is a CbNT requirement. The alignement is not an issue since the bootblock is a fixed size. If that were to change it would be easy to add this alignment requirement to the linker script.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd94539a6025e7c3912730a6d90454379d85fb59
Gerrit-Change-Number: 45652
Gerrit-PatchSet: 15
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Tue, 03 Nov 2020 08:15:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment