Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70255 )
Change subject: superio/nuvoton/nct5104d/chip.h: Use 'bool' when appropriate ......................................................................
superio/nuvoton/nct5104d/chip.h: Use 'bool' when appropriate
Change-Id: Idb321302bc82eb1b73bc1e732b82b9f726d2f363 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb M src/superio/nuvoton/nct5104d/chip.h M src/superio/nuvoton/nct5104d/superio.c 6 files changed, 23 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/70255/1
diff --git a/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb index 243a9ba..5e330f3 100644 --- a/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb @@ -32,8 +32,8 @@ device pci 14.0 on end # SM device pci 14.3 on # LPC 0x439d chip superio/nuvoton/nct5104d # SIO NCT5104D - register "irq_trigger_type" = "0" - register "reset_gpios" = "1" + register "irq_trigger_type" = "false" + register "reset_gpios" = "true" device pnp 2e.0 off end device pnp 2e.2 on io 0x60 = 0x3f8 diff --git a/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb index 8273a96..932eb8e 100644 --- a/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb @@ -32,8 +32,8 @@ device pci 14.0 on end # SM device pci 14.3 on # LPC 0x439d chip superio/nuvoton/nct5104d # SIO NCT5104D - register "irq_trigger_type" = "0" - register "reset_gpios" = "1" + register "irq_trigger_type" = "false" + register "reset_gpios" = "true" device pnp 2e.0 off end device pnp 2e.2 on io 0x60 = 0x3f8 diff --git a/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb index f399d8b..59b1b79 100644 --- a/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb @@ -32,8 +32,8 @@ device pci 14.0 on end # SM device pci 14.3 on # LPC 0x439d chip superio/nuvoton/nct5104d # SIO NCT5104D - register "irq_trigger_type" = "0" - register "reset_gpios" = "1" + register "irq_trigger_type" = "false" + register "reset_gpios" = "true" device pnp 2e.0 off end device pnp 2e.2 on io 0x60 = 0x3f8 diff --git a/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb b/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb index c69401b..a08cf0d 100644 --- a/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb +++ b/src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb @@ -32,7 +32,7 @@ device pci 14.0 on end # SM device pci 14.3 on # LPC 0x439d chip superio/nuvoton/nct5104d # SIO NCT5104D - register "irq_trigger_type" = "0" + register "irq_trigger_type" = "false" device pnp 2e.0 off end device pnp 2e.2 on io 0x60 = 0x3f8 diff --git a/src/superio/nuvoton/nct5104d/chip.h b/src/superio/nuvoton/nct5104d/chip.h index a251aa5..2e2ca42 100644 --- a/src/superio/nuvoton/nct5104d/chip.h +++ b/src/superio/nuvoton/nct5104d/chip.h @@ -3,9 +3,11 @@ #ifndef SUPERIO_NUVOTON_NCT5104D_CHIP_H #define SUPERIO_NUVOTON_NCT5104D_CHIP_H
+#include <stdbool.h> + struct superio_nuvoton_nct5104d_config { - u8 irq_trigger_type; - u8 reset_gpios; + bool irq_trigger_type; + bool reset_gpios; };
#endif diff --git a/src/superio/nuvoton/nct5104d/superio.c b/src/superio/nuvoton/nct5104d/superio.c index cfa2228..fea4b57 100644 --- a/src/superio/nuvoton/nct5104d/superio.c +++ b/src/superio/nuvoton/nct5104d/superio.c @@ -173,12 +173,12 @@ switch (dev->path.pnp.device) { case NCT5104D_SP1: case NCT5104D_SP2: - set_irq_trigger_type(dev, conf->irq_trigger_type != 0); + set_irq_trigger_type(dev, conf->irq_trigger_type != false); break; case NCT5104D_SP3: case NCT5104D_SP4: route_pins_to_uart(dev, true); - set_irq_trigger_type(dev, conf->irq_trigger_type != 0); + set_irq_trigger_type(dev, conf->irq_trigger_type != false); break; case NCT5104D_GPIO0: case NCT5104D_GPIO1: