Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37643 )
Change subject: Documentation: Add proposal for firmware testing
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201...
File Documentation/technotes/2019-12-firmware-testing.md:
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201...
PS7, Line 6: both Chrome OS test
: runners assume that the DUT (Device Under Test) has an operational
: kernel + network + sshd
The tast design principles (https://chromium.googlesource. […]
It's not just moving the connection somewhere else. The test system also (for the most part) assumes that the interaction over that connection is "run a program on the DUT" which we also don't do.
I guess we could get rid of that as well, but at what point are we just stuffing two completely different systems into a single binary?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb9380050f8ff1aa13ecbb501079e2556e43ca06
Gerrit-Change-Number: 37643
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Jett Rink
jettrink@chromium.org
Gerrit-CC: Kevin Shelton
kmshelton@google.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philip Chen
philipchen@google.com
Gerrit-CC: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Fri, 14 Feb 2020 15:07:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Shelton
kmshelton@google.com
Gerrit-MessageType: comment