Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39484 )
Change subject: memrange: Add support for stealing required memory from given ranges ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39484/3/src/lib/memrange.c File src/lib/memrange.c:
https://review.coreboot.org/c/coreboot/+/39484/3/src/lib/memrange.c@410 PS3, Line 410: if (!IS_ALIGNED(align, ranges->align))
Dropped this as part of https://review.coreboot. […]
Sorry, I must have missed your comment earlier. Just noticed your comment was from March 26 when I received notification for the other comments.
https://review.coreboot.org/c/coreboot/+/39484/3/src/lib/memrange.c@422 PS3, Line 422: continue;
For the limit - yes. But, I don't think that applies to r->end. […]
https://review.coreboot.org/c/coreboot/+/41104
https://review.coreboot.org/c/coreboot/+/39484/3/src/lib/memrange.c@433 PS3, Line 433: limit
Yes, it is inclusive. I will update the comment.
https://review.coreboot.org/c/coreboot/+/41103