View Change
3 comments:
File src/lib/memrange.c:
Patch Set #3, Line 410: if (!IS_ALIGNED(align, ranges->align))
Dropped this as part of https://review.coreboot. […]
Sorry, I must have missed your comment earlier. Just noticed your comment was from March 26 when I received notification for the other comments.
Patch Set #3, Line 422: continue;
For the limit - yes. But, I don't think that applies to r->end. […]
https://review.coreboot.org/c/coreboot/+/41104
Patch Set #3, Line 433: limit
Yes, it is inclusive. I will update the comment.
https://review.coreboot.org/c/coreboot/+/41103
To view, visit change 39484. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe9cfae18fc6101ab2e7e27233e45324c8117708
Gerrit-Change-Number: 39484
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 06 May 2020 20:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org>
Gerrit-MessageType: comment