[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Add SPI GPIO driving setting

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32460 )

Change subject: mediatek/mt8183: Add SPI GPIO driving setting
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/32460/2/src/soc/mediatek/mt8183/mt8183.c 
File src/soc/mediatek/mt8183/mt8183.c:

https://review.coreboot.org/#/c/32460/2/src/soc/mediatek/mt8183/mt8183.c@23 
PS2, Line 23: 	gpio_set_spi_driving();
> If this is required for SPI flash access, don't we need to set it in the bootblock? This function ru […]

I'm probably fine if this is set only after verstage if that helps reducing bootblock size. We read much more data after that...

If you're moving this to bootblock can you also double check if the size has been increased and how much?