Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46686 )
Change subject: ec/google/chromeec: Add more wrappers for regulator control
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h...
PS1, Line 358: * @param index Regulator ID
One blank line before parameter list.
Ack
https://review.coreboot.org/c/coreboot/+/46686/1/src/ec/google/chromeec/ec.h...
PS1, Line 365: * Query if the regulator is enabled.
One blank line before parameter list.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia804242042b0026af19025a0c4a74b3ab8475dab
Gerrit-Change-Number: 46686
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Oct 2020 14:33:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment