Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39139 )
Change subject: drivers/intel/fsp2_0: Add force memory retraining ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/39139/1/src/drivers/intel/fsp2_0/me... PS1, Line 282: __weak : bool is_the_same_memory_dimm(FSPM_UPD *upd, const void *data, size_t *data_sz) : { : return TRUE; : } : : __weak : void mainboard_prepare_dimm_info(FSPM_UPD *upd, void *data, size_t *data_sz) : { : data = NULL; : *data_sz = 0; : } Do you need these? You'd want a build failure if no implementation is provided instead of using invalid weakly linked functions.