[coreboot-gerrit] Change in coreboot[master]: intel/common/pmc: Add functions for IPC mailbox in ACPI

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46259 )

Change subject: intel/common/pmc: Add functions for IPC mailbox in ACPI
......................................................................

Patch Set 13: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46259/11/src/soc/intel/common/block... 
File src/soc/intel/common/block/pmc/pmc_ipc.c:

https://review.coreboot.org/c/coreboot/+/46259/11/src/soc/intel/common/block... 
PS11, Line 127: 	/* Package with return value and read buffer. */
              : 	acpigen_write_name("RVAL");
              : 	acpigen_write_package(5);
              : 	for (i = 0; i < 5; ++i)
              : 		acpigen_write_integer(0);
              : 	acpigen_pop_len();
              :
> Done. […]

Yeah there's the implicit mutex around its usage now; if other usages come up, we may have to dynamically create the object or add locking