12 Nov
2019
12 Nov
'19
4:45 a.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
Patch Set 17:
Patch Set 17: Code-Review+1
(2 comments)
looks good to me, but i currently don't have the time to check the register names and offsets, so I'm a bit hesitant to hit +2. if someone else wants to do that, please go ahead
Since I copied the tables from the datasheet and just did some regex replace, most names *should* be correct. I just hope I didn't copy another wrong table like I did for I2C :D
--
To view, visit https://review.coreboot.org/c/coreboot/+/35189
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bba1252635b3421051dd53f7d5adbd3d73ed1b6
Gerrit-Change-Number: 35189
Gerrit-PatchSet: 17
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 Nov 2019 12:45:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment