Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 52:
(4 comments)
https://review.coreboot.org/c/coreboot/+/30987/47/Documentation/mainboard/as... File Documentation/mainboard/asus/a88xm-e.md:
https://review.coreboot.org/c/coreboot/+/30987/47/Documentation/mainboard/as... PS47, Line 64: the vendor EFI binary
Are you sure? the command looks wrong
Done.
https://review.coreboot.org/c/coreboot/+/30987/47/Documentation/mainboard/as... PS47, Line 98: Kaveri/Godavary
Don't these use a different AGESA? (well, binaryPI)
Done.
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/mainboard.c:
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 47: the dedicated function
Which dedicated function? Maybe look up the MSR meanings?
Done.
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/mptable.c:
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 137: /*Local Ints: Type Polarity Trigger Bus ID IRQ APIC ID PIN# */
This comment does not correspond to the code below...
Done.