Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/29028 )
Change subject: mainboard/google/kahlee: Set PSPP setting to BalanceLow ......................................................................
mainboard/google/kahlee: Set PSPP setting to BalanceLow
With correct stapm values audio issue is not observed with PsPPBalanceLow (Gen1 speed).
BUG=b:117569918 TEST=audio playback multiple times
Change-Id: Iaeae52b262b12622a6753432e3fc40bf5f0fd8e0 Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com Reviewed-on: https://review.coreboot.org/29028 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Marc Jones marc@marcjonesconsulting.com Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marc Jones: Looks good to me, approved Martin Roth: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c index f5cab08..e9cf5c8 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c +++ b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c @@ -149,7 +149,7 @@ VOID __weak OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly) { InitEarly->GnbConfig.PcieComplexList = (void *)&PcieComplex; - InitEarly->GnbConfig.PsppPolicy = PsppBalanceHigh; + InitEarly->GnbConfig.PsppPolicy = PsppBalanceLow; InitEarly->PlatformConfig.GnbAzI2sBusSelect = GnbAcpI2sBus; InitEarly->PlatformConfig.GnbAzI2sBusPinConfig = GnbAcp2Tx4RxBluetooth; if ((IS_ENABLED(CONFIG_BOARD_GOOGLE_LIARA)) && (board_id() <= 4))