Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41368 )
Change subject: nb/intel/i440bx: add resources during read_resources() ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41368/2/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/northbridge.c:
https://review.coreboot.org/c/coreboot/+/41368/2/src/northbridge/intel/i440b... PS2, Line 37: pci_tolm = find_pci_tolm(dev->link_list);
Looks like this chipset has a max of 512MiB of ram (or 1GiB with registered dimms). […]
I think this is wrong, but in practice from a device configurations that exist we can land this change then remove find_pci_tolm() from this function as it doesn't serve a proper purpose.
There is no resource when there is an overlap anyway -- though that would be a major bug in an of itself. I'll send up an CL to remove this as a follow up.