Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28101 )
Change subject: Makefile: Write .xcompile to $(obj)
......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10:
Patch Set 10:
Not sure how to set this as WIP until I get Martin's comments addressed.
Overflow menu in the top right, "mark as work in progress"?
Only thing listed in that menu is:
Cherry pick
Download patch
Follow-up
Ignore
Mark unreviewed
I'll recheck permissions for that feature, thanks for the heads-up. marking WIP for you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia83f234447b977efa824751c9674154b77d606b0
Gerrit-Change-Number: 28101
Gerrit-PatchSet: 10
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Raul Rangel
rrangel@google.com
Gerrit-Comment-Date: Mon, 09 Dec 2019 19:35:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment