Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ......................................................................
Patch Set 68:
(8 comments)
What’s up with the file mod changes?
https://review.coreboot.org/c/coreboot/+/32734/68//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/32734/68//COMMIT_MSG@12 PS68, Line 12: SeaBios SeaBIOS
https://review.coreboot.org/c/coreboot/+/32734/68//COMMIT_MSG@12 PS68, Line 12: * SeaBios payload : * LinuxBoot payload What version?
https://review.coreboot.org/c/coreboot/+/32734/68//COMMIT_MSG@20 PS68, Line 20: Tianocore TianoCore
https://review.coreboot.org/c/coreboot/+/32734/68//COMMIT_MSG@25 PS68, Line 25: Please apply those patches as well for good user experience: : : I456be647b159f7a2ea7d94986a24424e56dcc8c4 : I22c6885eae6fd7c778ac37b18f95b8775e9064e3 : Ica0c20255f661dd61edc3a7d15646b7447c4658e This should be a comment, and not in the commit message in my opinion.
https://review.coreboot.org/c/coreboot/+/32734/68//COMMIT_MSG@30 PS68, Line 30: Does ACPI S3 work?
https://review.coreboot.org/c/coreboot/+/32734/68/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/32734/68/Documentation/mainboard/su... PS68, Line 15: Flashing flashing
https://review.coreboot.org/c/coreboot/+/32734/68/Documentation/mainboard/su... PS68, Line 29: - MP init causes secondary APs to crash (fix in gerrit). Mention the Change-Ids/URLs here?
https://review.coreboot.org/c/coreboot/+/32734/68/Documentation/mainboard/su... PS68, Line 40: SuperIO Super I/O