6 Sep
2022
6 Sep
'22
5:21 p.m.
Attention is currently required from: Ahamed Husni, Tim Wawrzynczak.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67340 )
Change subject: bd82x6x/early_pch: enable smbus in bootblock stage ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67340/comment/45488ea4_7f091500 PS2, Line 8: Can you add the reason why.
File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/c/coreboot/+/67340/comment/2d48193b_c8c33cde PS2, Line 316: ENV_RAMINIT no need to use the pre-processor:
`if (ENV_RAMINIT || (CONFIG(CONSOLE_I2C_SMBUS) && (ENV_RAMINIT || ENV_INITIAL_STAGE))`
--
To view, visit https://review.coreboot.org/c/coreboot/+/67340
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97d0afb013ede428383acaa0aa97ab04fe80e2a4
Gerrit-Change-Number: 67340
Gerrit-PatchSet: 2
Gerrit-Owner: Ahamed Husni ahamedhusni73@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Ahamed Husni ahamedhusni73@gmail.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 06 Sep 2022 15:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment